Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add typedocs for Worker.return/0 #1108

Merged
merged 6 commits into from
Jun 21, 2024
Merged

Add typedocs for Worker.return/0 #1108

merged 6 commits into from
Jun 21, 2024

Conversation

yordis
Copy link
Contributor

@yordis yordis commented Jun 21, 2024 •
edited
Loading

image

sorentwo
sorentwo reviewed Jun 21, 2024
View reviewed changes
Copy link
Member

@sorentwo sorentwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement.

lib/oban/worker.ex Outdated Show resolved Hide resolved
lib/oban/worker.ex Outdated Show resolved Hide resolved
lib/oban/worker.ex Outdated Show resolved Hide resolved
sorentwo
sorentwo reviewed Jun 21, 2024
View reviewed changes
lib/oban/worker.ex Outdated Show resolved Hide resolved
sorentwo
sorentwo reviewed Jun 21, 2024
View reviewed changes
lib/oban/worker.ex Outdated Show resolved Hide resolved
yukster
yukster approved these changes Jun 21, 2024
View reviewed changes
Copy link

@yukster yukster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big thumbs up! 👍

@yordis yordis requested a review from sorentwo June 21, 2024 17:58
@sorentwo sorentwo merged commit d9ca12b into oban-bg:main Jun 21, 2024
2 checks passed
@sorentwo sorentwo changed the title chore: improve docs Add typedocs for Worker.return/0 Jun 21, 2024
@yordis yordis deleted the chore-docs branch June 21, 2024 18:29
sorentwo added a commit that referenced this pull request Jun 25, 2024
@yordis @sorentwo
Add typedocs for Worker.return/0 type (#1108)
1c9e0b8 
Explain all of the return types and indicate that :discard is deprecated.

---------

Co-authored-by: Parker Selbert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yukster yukster yukster approved these changes

@sorentwo sorentwo Awaiting requested review from sorentwo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yordis @yukster @sorentwo